Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix File lib dependency issue #13

Closed
wants to merge 3 commits into from
Closed

Conversation

sandeep-paliwal
Copy link
Contributor

aio-lib-files was having issues with azure blob-storage npm usage in certain operation due to dependency conflict because of swagger client used in other sdk libs.
Moving its import on top fixes the issue for now

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] I have signed the Adobe Open Source CLA.
  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

aio-lib-files was having issues with azure blob-storage npm usage in certain operation due to dependency conflict because of swagger client used in other sdk libs.
Moving its import on top fixes the issue for now
@meryllblanchet
Copy link
Contributor

Note: @sandeep-paliwal to run e2e tests for each SDK library exported from aio-sdk

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #13 (186311a) into master (0058f3e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           10        10           
=========================================
  Hits            10        10           
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0058f3e...186311a. Read the comment docs.

@sandeep-paliwal
Copy link
Contributor Author

After running e2e tests found that these changes cause issues with other sdk imported after File lib.

@purplecabbage
Copy link
Member

I am assuming this PR is no longer required, given the comment above that it then breaks other things.
Can we close this @sandeep-paliwal ?

@sandeep-paliwal
Copy link
Contributor Author

@purplecabbage yup, this PR is no longer relevant. closing this one.

@purplecabbage purplecabbage deleted the File-patch-1 branch November 27, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants