Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap theme search to iframe search-frame page #1342

Merged
merged 11 commits into from
Jan 30, 2023

Conversation

dmitrymatio
Copy link
Collaborator

@dmitrymatio dmitrymatio commented Jan 30, 2023

Description

The theme will now iframe the search page at /search-frame/ like our Franklin pages do already.
This will point to the same search page once deployed site wide.
The search frame will communicate pathname to be mapped to assign local product filter as user moves around the site.

Additional bug fixes:

  • indexPrefix undefined error on page load with query parameters
  • undefined links when setting link.target while loading results
  • aio-Search-close button missing error when testing on search-frame page

Related Issue

DEVSITE-646

Motivation and Context

Propagating upgrades to search is a major effort due to the decentralized nature of the current search architecture.
A more centralized approach will simplify the search maintenance and make the experience much more consistent site wide.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dmitrymatio dmitrymatio merged commit 0eb7e75 into main Jan 30, 2023
@dmitrymatio dmitrymatio deleted the SEARCH/DEVSITE-646-iframed-search-test branch January 30, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants