AF-30 Clustering implementation #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Now messages will be processed/broadcaster only if sum is unique * Fixed a couple of cluster init issues * Moved cluster hooks to use messages instead of maps * Moved integration test logging to use node name instead of node address - it's harder to figure out what's happening with randomly generated port then with the node name. * Added long chain (5 locations) cluster sync & simple cluster tests * Added proper tests fish node stop procedure
This allows to use Resource directly when the Application is already running
10 tasks
sparshev
added a commit
that referenced
this pull request
Feb 23, 2024
Fixed multiple issues with Native driver on macos - mostly: * Proper passing of metadata as env variables to the workload - sudo & su are quite prohibitive there and to not make the node config harder I used just storing the metadata to env export variable and source it in the shell command. The file is stored in tmp and available via ACL to the newly created user only. * Proper log output for the workload right into the node log - it prepends stdout/stderr lines with the resource identifier and looks nice. * Using current fish node group as dynamic user group by default - otherwise the user is incomplete. * Configuration for the binaries location - by default it tries to find it in PATH, but now it's easy to override. * Modern MacOS on M1 doesn't allow to remove the created user, so have to give aquarium-fish binary "Full Disk Access" permission (added to wiki). Also a couple of small improvements: * Moved improved tests helpers from #54 * Moved a couple of fixes for build system from #54 * Found & fixed issue with single-process archiving during the build on macos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should add a proper clustering support with all the great functionality we had and even more with resistance to brain-split.
The change is BREAKING because removes the node description: not actually needed since all the decisions are made on the node itself.
TODO: Add more tests and proper documentation of each aspect of the cluster.
Related Issue
#30
Motivation and Context
Without a p2p cluster - what a life?
How Has This Been Tested?
Automatically
Screenshots (if appropriate):
Types of changes
Checklist: