Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with running mac nodes on AWS #56

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fixed issue with running mac nodes on AWS #56

merged 1 commit into from
Nov 10, 2023

Conversation

sparshev
Copy link
Collaborator

Description

Fixed a small issue during running an actual mac machine using AWS provider.

Also btw fixed sed command during the build on mac, because was incompatible with bsd sed.

Related Issue

None

How Has This Been Tested?

Manual - allocate/destroy of the mac2.metal type instance

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sparshev sparshev added the bug Something isn't working label Nov 10, 2023
@sparshev sparshev self-assigned this Nov 10, 2023
@sparshev sparshev merged commit bd3dd05 into main Nov 10, 2023
4 checks passed
@sparshev sparshev deleted the aws_mac_fix branch November 10, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant