Fix crash with open file. #45
Conversation
|
reviewing |
| @@ -227,7 +227,7 @@ class BracketsExtensionHandler : public CefV8Handler | |||
| bool canChooseFiles = !canChooseDirectories; | |||
| std::string title = arguments[2]->GetStringValue(); | |||
| std::wstring wtitle = StringToWString(title); | |||
| std::string initialPath = arguments[3]->GetStringValue(); | |||
There was a problem hiding this comment.
(I can't figure out how to insert a comment in the full file view, but a few lines up...) the code does array bounds checking by verifying the length of the array, but it does not verify that the array elements, which are assumed to be ptrs, are non-null. IOW, the code should check (arguments[i] != null) for each i.
There was a problem hiding this comment.
CEF always passes non-null values for arguments, even if null or undefined are passed to the JavaScript layer. I don't think we need an additional null check here- if null is passed, something is seriously wrong and the app will crash, regardless of what this function does.
There was a problem hiding this comment.
Since this dialog was called from JS, and we want to be extensible, it seemed like a good thing to check. But I verified that passing null doesn't crash, so it seems to be OK as it is.
@peterflynn
Fixes issue #39.