This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Improve search results for the empty query #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lts to disappear.
ghost
assigned 
|
Looking good merging |
couzteau
added a commit
that referenced
this pull request
May 23, 2013
…-query Improve search results for the empty query
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug/feature in the EWF search dialog in which the empty search query will return no results. This was actually done intentionally by @joelrbrandt to work around a Chrome bug that can cause a crash if too many file descriptors are opened at once. This can happen if we try to show result tiles for all the fonts at once, which is what one might otherwise wish to do in this case. The recent change that focused the search dialog box by default exacerbated this problem for complicated reasons that I won't go into here.
ANYWAY, this pull request changes the way search results are returned for the empty query. It now shows just those results that match the chosen font classification as indicated by the selected button on the left side. (This is also how the search results have historically been initialized.)