Skip to content
This repository has been archived by the owner on Jun 20, 2018. It is now read-only.

Installation failure #65

Closed
akjoshi opened this issue Jan 5, 2014 · 13 comments
Closed

Installation failure #65

akjoshi opened this issue Jan 5, 2014 · 13 comments

Comments

@akjoshi
Copy link
Contributor

akjoshi commented Jan 5, 2014

I cannot get this installed in Brackets - tried both options -a) Install from URL b) downloaded a zip file and placed in www/extensions/user/ directory.

@redmunds
Copy link
Contributor

redmunds commented Jan 5, 2014

Try using Help > Show Extensions Folder then install there.

@peey
Copy link

peey commented Jan 5, 2014

The problem mentioned is reproducible. This extension is working correctly in Sprint 30, but not in Sprint 35. None of the methods (url,zip file or inbuilt extension installer) work.

@peterflynn
Copy link
Member

@peey What happens when you place the zip file in the extensions/user folder manually? When you restart Brackets, does the PhoneGap icon appear in the right-hand toolbar?

If not, could you go to Help > Show Developer Tools, then select the Console view, and reply back with any errors that are listed there?

@peterflynn
Copy link
Member

@peey Also, when you download and install the ZIP manually, make sure:

  1. You're downloading the same version that's in the registry -- use this URL: https://s3.amazonaws.com/extend.brackets/brackets-phonegap/brackets-phonegap-0.1.0.zip
  2. You unzip it and place the "brackets-phonegap-master" directly in the "user" folder -- so that the path "...extensions/user/brackets-phonegap-master/package.json" is valid. (That is, make sure there aren't extra levels of nesting left over from the unzipping process).

@peterflynn
Copy link
Member

Oh, figured it out: this broke because of the minification. The extension is doing things like require("widgets/bootstrap-alerts.js") to load modules directly out of the Brackets source tree, without going through brackets.getModule(). Apparently this works when the full src structure is present (earlier sprints, or in a dev environment). (I have no idea why it would work, though. I thought extensions run in a Require context where the Require root is set to the root of the extension... it seems to be falling back to the Brackets core root in this case. Aside: @dangoor does that make any sense to you?).

Anyway, it definitely doesn't work in the new world where src is minified... and it wasn't supposed to work before, either :-)

@tpryan Do you have any cycles to look at this? I think you may need to ship a copy of these modules in the PG plugin itself. Because the modules you need aren't used by Brackets core at all, I think they're going to be totally absent from the minified builds.

@dangoor
Copy link

dangoor commented Jan 13, 2014

@peterflynn Yeah, the extension loading configuration sets the baseUrl to the extension. It doesn't seem like it should be somehow finding something elsewhere in the Brackets source tree.

@akjoshi
Copy link
Contributor Author

akjoshi commented Jan 22, 2014

Thanks everyone for investigating further on this issue. Just wondering if there's any fix or workarounds.

@cfjedimaster
Copy link
Contributor

I forked it, grabbed the JS files from Bootstrap (my assumption based on the age of this extension was that I should use 2.X) and it now loads w/o error. I haven't tried actually using it (outside of opening the panel), but it loads.

@peey
Copy link

peey commented Apr 12, 2014

Has this been fixed yet?

@cfjedimaster
Copy link
Contributor

I think so - did you check the Extension Manager?

@redmunds
Copy link
Contributor

No, the Extension Manager still has version 0.1.0 since the person that posted the extension has not updated the Registry. We are working on implementing an admin panel, so it shouldn't be much longer, but you'll still need to manually install this extensions for now.

@peey
Copy link

peey commented Apr 12, 2014

It's working now, if I install manually (from github url)

@redmunds
Copy link
Contributor

Fixed. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants