Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Substitute for #124 #125

Merged
merged 1 commit into from Oct 10, 2012

Conversation

Projects
None yet
2 participants
Contributor

DennisKehrig commented Oct 8, 2012

Modified fix for adobe/brackets#1147 (and probably adobe/brackets#1689) based on Glenn's work in #120.

Makes sure that the default size definitely fits the available space. It will only be used on the first launch of Brackets. Subsequent launches use stored window size and position which is adjusted automatically by the OS.

Modified fix for adobe/brackets#1147 based on Glenn's work in #120
Makes sure that the default size definitely fits the available space. It will only be used on the first launch of Brackets.
Subsequent launches use stored window size and position which is adjusted automatically by the OS.

@ghost ghost assigned jasonsanjose Oct 8, 2012

Member

jasonsanjose commented Oct 9, 2012

Reviewing

Member

jasonsanjose commented Oct 9, 2012

I wasn't able to reproduce adobe/brackets#1147 in the current master branch with Glenn's changes on my macbook air at 800x600. Is there another trick to get it to reproduce without commenting those lines out and recompiling?

Member

jasonsanjose commented Oct 9, 2012

Looks good. Just wanted to confirm the existing bug with @DennisKehrig.

Contributor

DennisKehrig commented Oct 10, 2012

You can try deleting /Users/<username>/Library/Preferences/io.brackets.appshell.plist
I also deleted io.brackets.appshell.plist.90T0uZH and io.brackets.appshell.plist.lockfile in the same directory, not sure that makes a difference.
I could reproduce the bug this way with daily build 2012-10-10_02-00-18.

Member

jasonsanjose commented Oct 10, 2012

Thanks @DennisKehrig. I was able to confirm the bug in the existing build at 800x600 and I also confirmed your fix. Merging.

jasonsanjose added a commit that referenced this pull request Oct 10, 2012

@jasonsanjose jasonsanjose merged commit 767a2f7 into adobe:master Oct 10, 2012

@jasonsanjose jasonsanjose referenced this pull request in adobe/brackets Oct 10, 2012

Closed

Display error on MacBook Pro (13") #1689

jasonsanjose added a commit that referenced this pull request Dec 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment