This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Don't update settings.locale with our detected locale from OS. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the crash caused by CEF loading the resources. Also remove the mappings that we put in before to fix crashes for Chinese OSes and Brazilian Portuguese.
ghost
assigned 
|
Yeah, this seems like the simplest approach to avoiding the crash for now. This does mean that CEF will always be run with english strings, but that only affects built-in HTML controls like input type=file and database controls, which we don't use in Brackets. Merging. |
gruehle
added a commit
that referenced
this pull request
Oct 10, 2012
Don't update settings.locale with our detected locale from OS.
gruehle
added a commit
that referenced
this pull request
Dec 8, 2015
Don't update settings.locale with our detected locale from OS.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the mappings that we put in before to fix crashes for Chinese OSes and Brazilian Portuguese.
I did try with CFLocaleCopyPreferredLanguages() and it returns the same locale ID as our current code [[NSLocale preferredLanguages] objectAtIndex:0]. So we can't use it either.
This fixes issue #1716