-
Notifications
You must be signed in to change notification settings - Fork 619
Add short version string to Info.plist #204
Conversation
@@ -20,6 +20,8 @@ | |||
<string>????</string> | |||
<key>CFBundleVersion</key> | |||
<string>0.20.0.0</string> | |||
<key>CFBundleShortVersionString</key> | |||
<string>0.20.0.0</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While updating version strings I noticed we use a different format than package.json: 0.20.0-0
. Should these versions here be changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. We have two options:
- Use "0.20.0" and leave off the build number
- Use "0.20.0-0" and have the scripts update the number here to match the number in package.json.
The first seems much simpler :-)
You could change the format when you update the version number to 21. Sound good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Option 1 sounds good for now. My interpretation of the docs though says that the short version should be 0.20.0 and the CFBundleVersion would be only our build number, e.g. 5672.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you dig in a bit further, the docs say to use "three, non-negative, period-separated integers" for CFBundleVersion:
http://developer.apple.com/library/ios/#documentation/general/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/TP40009249-SW1
However, a quick (and entirely non-scientific) survey of two apps look quite different:
- Photoshop uses "13.0.1.519" for CFBundleVersion and "13.0.1" for CFBundleShortVersionString
- Sublime Text uses "2217" for CFBundleVersion and "Version 2.0.1, Build 2217" for CFBundleShortVersionString
I don't know where CFBundleVersion is used. I do know that CFBundleShortVersionString is used in the Finder "Get Info" dialog and when right-clicking and selecting "Open With >" (the number is in parens after the app name)
Just checking in. You were going to go with option 1 right? And leave CFBundleVersion alone? |
I updated both CFBundleShortVersionString and CFBundleVersion for consistency. Eventually your grunt scripts could put the correct build number in CFBundleVersion, if needed. |
Merging. |
Add short version string to Info.plist
Add short version string to Info.plist
Fixes adobe/brackets#2835