Allow brackets to be dragged by the caption bar alot easier #345

Merged
merged 2 commits into from Oct 3, 2013

Conversation

Projects
None yet
2 participants
Contributor

JeffryBooher commented Oct 2, 2013

@ghost ghost assigned redmunds Oct 2, 2013

appshell/cef_dark_window.cpp
+ ::CopyRect(&dest, &rect);
+ ::UnionRect(&dest, &rect, &itemRect);
+ ::CopyRect(&rect, &dest);
+ }
@redmunds

redmunds Oct 3, 2013

Contributor

I don't think the first ::CopyRect is necessary. It copies rect to dest, then ::UnionRect overwites the value you just put in dest. I think you can safely remove that line.

@JeffryBooher

JeffryBooher Oct 3, 2013

Contributor

@redmunds I was error-ing on the side of caution here but I think you're right. Removed.

Contributor

redmunds commented Oct 3, 2013

Done with code review. Works great! One possible optimization.

Contributor

redmunds commented Oct 3, 2013

Looks good. Merging.

redmunds added a commit that referenced this pull request Oct 3, 2013

Merge pull request #345 from adobe/jeff/dark-shell-fixes
Allow brackets to be dragged by the caption bar alot easier

@redmunds redmunds merged commit 85501c6 into master Oct 3, 2013

@redmunds redmunds deleted the jeff/dark-shell-fixes branch Oct 3, 2013

redmunds added a commit that referenced this pull request Dec 8, 2015

Merge pull request #345 from adobe/jeff/dark-shell-fixes
Allow brackets to be dragged by the caption bar alot easier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment