This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Allow brackets to be dragged by the caption bar alot easier #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| ::CopyRect(&dest, &rect); | ||
| ::UnionRect(&dest, &rect, &itemRect); | ||
| ::CopyRect(&rect, &dest); | ||
| } |
There was a problem hiding this comment.
I don't think the first ::CopyRect is necessary. It copies rect to dest, then ::UnionRect overwites the value you just put in dest. I think you can safely remove that line.
There was a problem hiding this comment.
@redmunds I was error-ing on the side of caution here but I think you're right. Removed.
|
Done with code review. Works great! One possible optimization. |
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Oct 3, 2013
Allow brackets to be dragged by the caption bar alot easier
redmunds
added a commit
that referenced
this pull request
Dec 8, 2015
Allow brackets to be dragged by the caption bar alot easier
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: