This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
CEF 2171 #492
Merged
CEF 2171 #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -164,14 +164,6 @@ void ClientHandler::OnAfterCreated(CefRefPtr<CefBrowser> browser) { | |||
|
|
|||
| bool ClientHandler::DoClose(CefRefPtr<CefBrowser> browser) { | |||
There was a problem hiding this comment.
We can get rid of this method completely, since the default in cef_life_span_handler.cpp is returning false.
|
I'm done with review. I had one comment for code removal. |
|
Thanks @JeffryBooher! |
ingorichter
added a commit
that referenced
this pull request
Dec 11, 2014
ingorichter
added a commit
that referenced
this pull request
Dec 8, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Mac and Windows to CEF 2171.
NOTE: The Linux builds will either fail or fail to start/terminate on this branch.
Linux will continue to use CEF 1547 until the issue has been addressed