Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Fix for #10686: White line along right edge of UI on high-DPI Windows #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for #10686: White line along right edge of UI on high-DPI Windows #507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appshell/cef_dark_aero_window.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ LRESULT cef_dark_aero_window::WindowProc(UINT message, WPARAM wParam, LPARAM lPa
if (mReady) {
UpdateNonClientArea();
}
break;
return 0L;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work ok but the app frame is no longer drawing in the active color when activated.
My guess is that Windows isn't sending WM_ACTIVATEAPP because you're preventing the WM_ACTIVATE message from reaching the default Window Proc but I haven't debugged this to determine if that is indeed the case.

    case WM_ACTIVATEAPP:
        mIsActive = (BOOL)wParam;
        UpdateNonClientArea();
        break;
    }
    return lr;

I guess technically you could just keep track of the active state from here but I wonder if there are other things that are broken.

case WM_NCMOUSELEAVE:
// NOTE: We want anyone else interested in this message
// to be notified. Otherwise the default implementation
Expand Down