Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Enable paste command #567

Merged
merged 1 commit into from Sep 1, 2016
Merged

Enable paste command #567

merged 1 commit into from Sep 1, 2016

Conversation

ficristo
Copy link
Collaborator

@ficristo ficristo commented Aug 14, 2016

With this we can now use document.execCommand("paste")
While testing Ubuntu 16.04 seems this change is unnecessary so I didn't write a PR for the linux-1547 branch.
OSX is untested.
On the web there are some security risk but I don't think for and editor it's the same.
Plus looking around seems VSCode use that command too.

@marcelgerber
Copy link
Contributor

Is there a reason this is in both cefclient_[mac/linux, but not Windows] and cef_main_window? Doesn't that mean it's called twice on these platforms? How does it work for Windows then?
Also, wouldn't it make sense to put it directly into cefclient (

settings.remote_debugging_port = REMOTE_DEBUGGING_PORT;
)?

@ficristo
Copy link
Collaborator Author

I was looking at web_security and it's only on those 3 files and it seems to me that cef_main_window is Windows specific code.
We cannot put in cefclient because those options are browser settings and not settings.

@zaggino
Copy link
Contributor

zaggino commented Aug 26, 2016

Tested on Windows, works as intented. LGTM

@ficristo ficristo added this to the Release 1.8 milestone Aug 26, 2016
@marcelgerber
Copy link
Contributor

LGTM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants