Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

node 6.3.1 for linux #574

Merged
merged 1 commit into from
Sep 3, 2016
Merged

node 6.3.1 for linux #574

merged 1 commit into from
Sep 3, 2016

Conversation

zaggino
Copy link
Contributor

@zaggino zaggino commented Aug 26, 2016

complements #543

@zaggino zaggino added this to the Release 1.8 milestone Aug 26, 2016
@zaggino
Copy link
Contributor Author

zaggino commented Aug 28, 2016

I've tested building this on Linux, file watching works as expected.

@ficristo
Copy link
Collaborator

ficristo commented Sep 2, 2016

I didn't run the full test suite here. This is what I noticed so far:

  • I've run all the Unit tests and KeyBindingManager has a couple of failures which I doubt is related
  • I've run Integration \ FindInFiles test with a failure which is not related (is on master too)
  • there are some problems under LivePreview tests
  • Extensions \ JSQuickEdit & JavaScript Code Hinting pass

@ficristo
Copy link
Collaborator

ficristo commented Sep 3, 2016

@marcelgerber could you test this too?

@marcelgerber
Copy link
Contributor

In my testing, the tests that failed were broken on linux-1547, too.
LGTM.

@marcelgerber marcelgerber merged commit a4b4da7 into linux-1547 Sep 3, 2016
@marcelgerber marcelgerber deleted the linux-1547-node6 branch September 3, 2016 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
high priority
Projects
None yet
Milestone
Release 1.8
3 participants
@zaggino @ficristo @marcelgerber