Fixing build issues on Ubuntu 18.04 #645
Conversation
| @@ -1,6 +1,7 @@ | |||
| #include "appshell/appshell_extensions_platform.h" | |||
| #include <unicode/ucsdet.h> | |||
| #include <unicode/ucnv.h> | |||
| #include <unicode/unistr.h> | |||
There was a problem hiding this comment.
Shouldn't the headers be added only for LINUX. Why add unnecessary headers on WIN/MAC if not needed?
There was a problem hiding this comment.
I'll move these header inclusion to #ifdef OS_LINUX
| @@ -34,6 +34,9 @@ | |||
| #ifdef OS_LINUX | |||
| #include <gtk/gtk.h> | |||
| #endif | |||
| #include <unicode/ucnv_err.h> | |||
There was a problem hiding this comment.
See my comment above for Linux only headers
There was a problem hiding this comment.
I'll move these header inclusion to #ifdef OS_LINUX
appshell/browser/client_handler.cc
Outdated
| @@ -337,13 +337,17 @@ bool ClientHandler::OnDragEnter(CefRefPtr<CefBrowser> browser, | |||
| } | |||
| #endif | |||
|
|
|||
| /** | |||
| * We do not plan to add any feature to parent class(::ClientHandler) implementation of this function, | |||
| * So override is useless | |||
| void ClientHandler::OnDraggableRegionsChanged( | |||
There was a problem hiding this comment.
Is the override causing a warning or an error? Do we need to change this on all platforms?
Test these changes on all platforms and make sure nothing breaks on WIN/MAC due to this.
appshell/browser/client_handler.h
Outdated
|
|
||
| /** | ||
| * We do not plan to add any feature to parent class(::ClientHandler) implementation of this function, | ||
| * So override is useless | ||
| void OnDraggableRegionsChanged( |
There was a problem hiding this comment.
See my comment above on override
appshell/cefclient_gtk.cc
Outdated
| namespace{ | ||
| template<typename T> | ||
| struct deleter | ||
| { |
There was a problem hiding this comment.
Remove these changes if not required.
There was a problem hiding this comment.
Moving these changes to a branch rather than the master branch.
No description provided.