CEF 3683 on Linux #666
CEF 3683 on Linux #666
Conversation
* CEF 3202 Mac * CEF 3202 * Complted Windows 32 build using Visual Studio 15 * Updated CEF version to 3.3497.1836.gb472a8d * updated CEF to 3.3538.1841.gdcdb070 * Updating gyp configs according to cef/cef_paths2.gypi in CEF-3.3538.1846.g678fa78 * fixing compiler warnings and linking errors * Disabled web-security to enable file:/// resource servicing, those were blocked by chromium for being cross origin. For file:// resource, hostnames are considered different despite pointing to same host * Corrected CEF url
…debugger window opened from it has copy paste working
| @@ -71,7 +72,7 @@ void CharSetEncode::operator()(std::string &contents) { | |||
| if(error != U_BUFFER_OVERFLOW_ERROR) { | |||
| throw "Unable to convert encoding"; | |||
| } | |||
| std::auto_ptr<char> target(new char[targetLen + 1]()); | |||
| std::unique_ptr<char> target(new char[targetLen + 1]()); | |||
There was a problem hiding this comment.
Why was this required? Is it just for a safety enhancement?
| @@ -272,32 +272,6 @@ void ClientHandler::OnFullscreenModeChange(CefRefPtr<CefBrowser> browser, | |||
| NotifyFullscreen(fullscreen); | |||
| } | |||
|
|
|||
| bool ClientHandler::OnConsoleMessage(CefRefPtr<CefBrowser> browser, | |||
There was a problem hiding this comment.
Shouldn't we leave the stub for debugging purposes?
| @@ -577,6 +551,7 @@ bool ClientHandler::OnCertificateError( | |||
| CefRefPtr<CefRequestCallback> callback) { | |||
| CEF_REQUIRE_UI_THREAD(); | |||
|
|
|||
| #if 0 | |||
There was a problem hiding this comment.
Better to remove this or add a configurable MACRO to handle this.
| @@ -28,7 +28,7 @@ CefRefPtr<CefBrowser> AppGetBrowser() { | |||
|
|
|||
| CefWindowHandle AppGetMainHwnd() { | |||
| if (!g_handler.get()) | |||
| return NULL; | |||
| return 0; | |||
There was a problem hiding this comment.
Why are we using an explicit integer for pointer here? CefWindowHandle is defined as HWND on Windows, NSView* on Mac OS X and GtkWidget* on Linux.
NULL seemed like a better choice. nullptr even better to handle type ambiguity with int.
| @@ -280,65 +278,6 @@ void ClientHandler::OnLoadingStateChange(CefRefPtr<CefBrowser> browser, | |||
| SetNavState(canGoBack, canGoForward); | |||
| } | |||
|
|
|||
| bool ClientHandler::OnConsoleMessage(CefRefPtr<CefBrowser> browser, | |||
There was a problem hiding this comment.
Some changes here are not limited to Linux. I would recommend Linux only changes for this PR.
|
@gautam0217 you also need to change: https://github.com/adobe/brackets-shell/blob/master/installer/linux/debian/control The
|
Basic brackets functionalities are working my local testing.
Only missing thing is copy-paste is disable on Debug > New Brackets Window.
Copy paste is working on all Debug windows opened.
CEF downloaded from spotify
ICU58 build from source using following config: