Fixes after first review

adobe · Mar 22, 2013 · 312a8f4 · 312a8f4
1 parent eb8eb01
commit 312a8f4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/editor/Editor.js b/src/editor/Editor.js
@@ -1334,7 +1334,7 @@ define(function (require, exports, module) {
      */
     function _setEditorOptionAndPref(value, cmOption, prefName) {
         _setEditorOption(value, cmOption);
-        _prefs.setValue(prefName, (typeof value === "boolean") ? Boolean(value) : value);
+        _prefs.setValue(prefName, value);
     }
 
     /**
@@ -1351,7 +1351,7 @@ define(function (require, exports, module) {
     Editor.getUseTabChar = function () {
         return _useTabChar;
     };
-
+    
     /**
      * Sets tab character width. Affects all Editors.
      * @param {number} value
@@ -1366,7 +1366,7 @@ define(function (require, exports, module) {
     Editor.getTabSize = function () {
         return _tabSize;
     };
-
+    
     /**
      * Sets indentation width. Affects all Editors.
      * @param {number} value

diff --git a/src/editor/EditorStatusBar.js b/src/editor/EditorStatusBar.js
@@ -103,10 +103,11 @@ define(function (require, exports, module) {
             return;
         }
 
+        value = Math.max(Math.min(value, 10), 1);
         if (Editor.getUseTabChar()) {
-            Editor.setTabSize(Math.max(Math.min(value, 10), 1));
+            Editor.setTabSize(value);
         } else {
-            Editor.setSpaceUnits(Math.max(Math.min(value, 10), 1));
+            Editor.setSpaceUnits(value);
         }
 
         // update indicator