Merge pull request #3688 from jeffslofish/Issue3131-copyable-jslint-e…

…rrors Issue #3131 - Making JSLint errors copyable
adobe · May 10, 2013 · d57cd75 · d57cd75
2 parents c27664b + 97d737c
commit d57cd75
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 19 deletions.
diff --git a/src/extensions/default/JSLint/htmlContent/bottom-panel.html b/src/extensions/default/JSLint/htmlContent/bottom-panel.html
@@ -1,4 +1,4 @@
-<div id="jslint-results" class="bottom-panel vert-resizable top-resizer no-focus">
+<div id="jslint-results" class="bottom-panel vert-resizable top-resizer">
     <div class="toolbar simple-toolbar-layout">
         <div class="title">{{JSLINT_ERRORS}}</div>
     </div>

diff --git a/src/styles/brackets.less b/src/styles/brackets.less
@@ -48,12 +48,7 @@ html, body {
     overflow: hidden;
 
     /* Turn off selection for UI elements */
-    -webkit-user-select: none;
-    -khtml-user-select: none;
-    -moz-user-select: none;
-    -ms-user-select: none;
-    -o-user-select: none;
-    user-select: none;
+    .user-select(none);
 
     /* And make sure we get a pointer cursor even over text */
     cursor: default;
@@ -839,3 +834,8 @@ li.smart_autocomplete_highlight {
         background-size: 100%;
     }
 }
+
+/* Turn on text selection for JSLint error messages */
+#jslint-results {
+    .user-select(text);
+}
diff --git a/src/styles/brackets_mixins.less b/src/styles/brackets_mixins.less
@@ -118,3 +118,14 @@
     -o-transform-origin: @horizontal @vertical;
     transform-origin: @horizontal @vertical;
 }
+
+/* Change the settings for user-select and its counterparts, defaulting to none. */
+.user-select(@type: none) {
+    -webkit-user-select: @type;
+    -khtml-user-select: @type;
+    -moz-user-select: @type;
+    -ms-user-select: @type;
+    -o-user-select: @type;
+    user-select: @type;
+}
+
diff --git a/src/styles/brackets_patterns_override.less b/src/styles/brackets_patterns_override.less
@@ -442,12 +442,7 @@
 
             // Enable text selection
             cursor: auto;
-            -webkit-user-select: text;
-            -khtml-user-select: text;
-            -moz-user-select: text;
-            -ms-user-select: text;
-            -o-user-select: text;
-            user-select: text;
+            .user-select(text);
         }
     }
 }
@@ -564,12 +559,7 @@
 
         // Enable text selection
         cursor: auto;
-        -webkit-user-select: text;
-        -khtml-user-select: text;
-        -moz-user-select: text;
-        -ms-user-select: text;
-        -o-user-select: text;
-        user-select: text;
+        .user-select(text);
     }
 }