Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

When renaming/naming a file in the file tree, the Enter key event is fired faster than last letter key #10048

Closed
EvHaus opened this issue Dec 1, 2014 · 6 comments

Comments

@EvHaus
Copy link

EvHaus commented Dec 1, 2014

When renaming/naming a file in the file tree, it seems that the "Enter" event is fired before the last letter entry is fired. The resulting behaviour is that the last letter typed is ignored after Enter is pressed.

So I will type "test" then immediately hit Enter, and the file will be called "tes". If, instead, I type "test" then wait a second, and then press Enter - then the file is named "test" correctly.

It's almost as if the text input is on a timeout, while the Enter listener is immediate.

@sohailb
Copy link

sohailb commented Dec 5, 2014

I tried looking into this. I am running a mac and I tried to rename files in the tree view and hit enter as quickly as I could (numerous times) and I am unable to reproduce this. Is this still happening for you?

@peterflynn
Copy link
Member

I can't get this to happen either. @globexdesigns can you try Debug > Reload Without Extensions and make sure it still happens then? Also, try Debug > Show Developer Tools and see if any errors are logged in the console.

@EvHaus
Copy link
Author

EvHaus commented Dec 5, 2014

Indeed, it appears to have been caused by the "Todo" extension. How could an extension have such an affect on the file tree?

I really wish there was a "Disable Extension" button, instead of an "Uninstall Extension" button. That would have made debugging much faster.

@TomMalbran
Copy link
Contributor

@globexdesigns To disable extensions you can open the extensions directory and move the folders from user to disabled and then you need to reload brackets. It is not as good as a disable option from the extensions manager, but at least is better than uninstalling.

@peterflynn
Copy link
Member

Closing since it's not a core Brackets bug.

Fwiw, we do have an item on our feature backlog for Enable / Disable Individual Extensions and we've talked about even adding an automatic "bisect mode" to pinpoint problems. But the manual process is pretty quick once you know how to do it. More info in our documentation here.

@EvHaus
Copy link
Author

EvHaus commented Jan 2, 2015

Upon further investigation, this is not an issue with an extension. The issue can be reproduced with no extensions installed. This is caused when the system memory is low (which is slightly more likely when you are running Brackets with extensions enabled, hence the red-herring).

I can only reproduce this on my Mac, with is often pegged at 7.9 / 8.0GB of memory use. Typing on the machine at this time is generally pretty slow and when it is -- I get the behavior described above.

Not sure how to suggest steps to reproduce other than to replicate high system memory usage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants