New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cut off parts of the new name when renaming #10648

Merged
merged 1 commit into from Mar 6, 2015

Conversation

Projects
None yet
3 participants
@MarcelGerber
Contributor

MarcelGerber commented Feb 22, 2015

Uses input event instead of keyUp to catch all changes to the input element. (It may also have cut off parts of the name when pasting, undoing, ...)

For #10531, #10618, #10048

cc @njx @dangoor

@ElegantScripting

This comment has been minimized.

Show comment
Hide comment
@ElegantScripting

ElegantScripting Feb 22, 2015

@MarcelGerber Thanks a bunch for this! I tried emailing you, but for some reason Google throws back an error, so it won't work. Is there any other way I can contact you?

ElegantScripting commented Feb 22, 2015

@MarcelGerber Thanks a bunch for this! I tried emailing you, but for some reason Google throws back an error, so it won't work. Is there any other way I can contact you?

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Feb 22, 2015

Contributor

You tried emailing me at mg.h***@gmx.de, right?
You can also mail me at mger*****@gmail.com and see if that works.
Otherwise, I'm currently on IRC in #brackets.

Contributor

MarcelGerber commented Feb 22, 2015

You tried emailing me at mg.h***@gmx.de, right?
You can also mail me at mger*****@gmail.com and see if that works.
Otherwise, I'm currently on IRC in #brackets.

prksingh added a commit that referenced this pull request Mar 6, 2015

Merge pull request #10648 from MarcelGerber/rename-no-cut-off
Don't cut off parts of the new name when renaming

@prksingh prksingh merged commit c4e83a6 into adobe:master Mar 6, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@prksingh

This comment has been minimized.

Show comment
Hide comment
@prksingh

prksingh Mar 6, 2015

Contributor

Merging. Thanks.

Contributor

prksingh commented Mar 6, 2015

Merging. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment