Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Live Preview (node) server is local only! #13687

Open
3 tasks done
benlogan opened this issue Sep 8, 2017 · 0 comments
Open
3 tasks done

Live Preview (node) server is local only! #13687

benlogan opened this issue Sep 8, 2017 · 0 comments

Comments

@benlogan
Copy link

benlogan commented Sep 8, 2017

Prerequisites

  • Can you reproduce the problem with Debug -> Reload Without Extensions?
  • Did you perform a cursory search to see if your bug or enhancement is already reported?
  • Did you read the Troubleshooting guide?

For more information on how to write a good bug report read here
For more information on how to contribute read here

Description

Live Preview is using a local only web server - not accessible from other machines. The problem is in StaticServerDomain.js;
server.listen(port, "127.0.0.1");
This limits connections to the localhost, it should simply be
server.listen(port);

Perhaps this was deliberate, but I remember being able to do this with earlier versions of Brackets.

Steps to Reproduce

  1. Run a 'live preview'
  2. Attempt to connect via a different host

Expected behavior: [What you expected to happen]
You should be able to access the server remotely - for quickly demonstrating POC's to colleagues etc.

Actual behavior: [What actually happened]
You can't!

Versions

Will affect all!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant