Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Status bar mode label inconsistent with nested modes #1825

Closed
peterflynn opened this issue Oct 12, 2012 · 5 comments
Closed

Status bar mode label inconsistent with nested modes #1825

peterflynn opened this issue Oct 12, 2012 · 5 comments
Assignees

Comments

@peterflynn
Copy link
Member

  1. Open an HTML file containing inline JS in a script block
  2. Put cursor inside the script block
  3. Switch to a different file
  4. Switch back

Result:
1-2: mode says "html"
4: mode says "javascript"

Expected:
Status bar consistently shows outermost mode of file ("html" in this case).

@peterflynn
Copy link
Member Author

Problem is that it's using the cursor-location-specific API Editor.getModeForSelection(). We should add a method for getting the top-level (file-wide) mode and use that instead.

Note that this will make #1826 a little more obvious though, since HTML files will start using the label "htmlmixed" if we're accurately reporting the outermode.

@njx
Copy link
Contributor

njx commented Oct 12, 2012

See comments on #1826 - moving to Sprint 16, could consider removing this from the status bar for the next Edge Code drop if we don't want to fix this yet.

@ghost ghost assigned redmunds Oct 15, 2012
@pthiess
Copy link
Contributor

pthiess commented Oct 15, 2012

Assigned to Randy.

@RaymondLim
Copy link
Contributor

FBNC to @peterflynn

@ghost ghost assigned peterflynn Oct 30, 2012
@peterflynn
Copy link
Member Author

Confirmed fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants