Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

You need two undos to reverse "Move line Up/Down" command. #1957

Closed
RaymondLim opened this issue Oct 25, 2012 · 5 comments
Closed

You need two undos to reverse "Move line Up/Down" command. #1957

RaymondLim opened this issue Oct 25, 2012 · 5 comments
Assignees

Comments

@RaymondLim
Copy link
Contributor

  1. Select multiple lines in a document and Press Ctrl/Cmd-Shift-Down/Up arrow to move line down/up.
  2. Press Ctrl/Cmd-Z to undo.

Result: The line above/below the originally selected lines is removed and not really restored to the previous state. If you undo one more time, then you get back the missing line.

It seems like "Move Line Up/Down" command is removing the above/below line first and then put that line to the opposite side of the selection. And we need to make these two operations into one atomic operation if possible.

@peterflynn
Copy link
Member

This was fixed by pull #2132. FBNC @RaymondLim

@ghost ghost assigned RaymondLim Nov 22, 2012
@RaymondLim
Copy link
Contributor Author

@peterflynn No, when I tried with a single line, I can't reproduce it. But if I tried with multiple lines as in step 1, then I still can reproduce the issue.

@TomMalbran
Copy link
Contributor

I cant reproduce it in the main editor, but I can in the inline editors. I think that the problem with the inline editors might be a different one to what we fixed at #2132.

@WebsiteDeveloper
Copy link
Contributor

i can not repoduce this issue seems to be fixed in the current master

@RaymondLim
Copy link
Contributor Author

Closing since I can't reproduce it in sprint 21 build.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants