This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Batch operation Fix #2132
Merged
Batch operation Fix #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Looks great, thanks Tomás! I've run with this change for a while and not seen any issues, and all unit tests pass for me too. |
peterflynn
added a commit
that referenced
this pull request
Nov 16, 2012
Fix Document.batchOperation() to guarantee a single monolithic Undo step
This was referenced Nov 16, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull was suggested by @peterflynn in #2108 to fix the edition undo.
Right now there are only 3 functions that use batchOperation:
With this pull all 3 functions would work as before, passing all the tests too, and it will also fix the undo issues on both Block comment and Move line up/down, on the main editor.
I did some tests on the cmv3 branch and the undo issues were still there. I implemented this patch on that branch too and after testing, everything worked perfectly, solving the undo issues too.