Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix Closure comments using ! operator #2360

Open
jasonsanjose opened this issue Dec 14, 2012 · 1 comment
Open

Fix Closure comments using ! operator #2360

jasonsanjose opened this issue Dec 14, 2012 · 1 comment

Comments

@jasonsanjose
Copy link
Member

Across the Brackets code base we use !function(...) incorrectly in our Closure @param annotations. function types are non-nullable by default. We should remove ! when appropriate and instead use ?function(...) for nullable parameters or function(...)= for optional parameters.

See #2063 (comment).

@pthiess
Copy link
Contributor

pthiess commented Dec 17, 2012

Low priority, assigned to @jasonsanjose

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants