NativeFileSystem documentation and examples (#1052) #2063
Conversation
ghost
assigned …ystem-doc Conflicts: src/file/NativeFileSystem.js
|
Assigned to me. @jbalsas Now that the other NativeFileSystem changes are merged, do you want to update this pull request or should I close this? |
|
Sure! Let me merge with master first and then review and update this before you take a look. |
…ystem-doc Conflicts: src/file/NativeFileSystem.js src/language/CSSUtils.js
|
@jasonsanjose Merged and updated. All yours ;) |
| * NativeFileSystem.DirectoryEntry().getDirectory(path, {create: true}); | ||
| * | ||
| * - CHECK IF A FILE OR FOLDER EXISTS | ||
| * NativeFileSystem.requestNativeFileSystem(path |
There was a problem hiding this comment.
I think resolveNativeFileSystemPath is a more appropriate example. Thoughts?
There was a problem hiding this comment.
Yes, makes sense. This wasn't implemented by the time I added the examples, though. Will switch to resolveNativeFileSystemPath here.
| /** | ||
| * Copies this Entry to a different location on the file system. | ||
| * @param {!DirectoryEntry} parent The directory to copy the entry to | ||
| * @param {!string=} newName The new name of the entry. If not specified, defaults to the current name |
|
Initial review complete. Thanks for taking this one. |
|
@jasonsanjose I'll dive into this later today. Just need one clarification. From the Closure Compiler docs, Is it possible that we're using Furthermore, if we stick to the meaning of What do you think? |
|
Yep, we're using You're right that it seems redundant to add |
|
I think I've addressed all your comments. Ready for a second pass. |
|
Looks great. I filed #2360 to cover the incorrect annotations. Merging. |
NativeFileSystem documentation and examples (#1052)
Hi,
I was going through
NativeFileSystemthe other day and ran across #1052This pull request should address those concerns. Additionally, it removes some unused requires with NativeFileSystem.
As pointed out in #2058, some of the APIs are not consitent with the current specs. The jsdocs here reflect the specs, and would need to get updated with that information.