-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Russian getting started folder name causes windows installer build to fail #2425
Comments
Yep -- apparently Wix has some sort of encoding setting that is unhappy with the Russian chars in the getting started folder name. Hopefully it's possible to make Wix just use UTF, although I'm not 100% sure since it's built on a somewhat archaic tech stack. For now, since we're up against a wall, we should just rename the folder name back to English (and then leave this open at a lower priority for a future sprint). |
@peterflynn I put this into sprint 19 ToInvestigate |
Reviewed. |
Here's the best info I could find on Wix and Unicode:
The display glitch hopefully isn't an issue for us since the Unicode pathname in question won't appear in the installer UI at any point. This sounds a little scary vis a vis our (semi-hacky) dual-locale MSI setup, which uses a mechanism called "transforms":
However, both the En & Fr halves of our installer are currently built with codepage set to 1252 (basically vanilla Latin ANSI), so it appears as if they're already happy being set to the same code page. Hopefully we could just as easily make them both Unicode instead of both 1252. My last concern would be how well the resulting MSI runs on Windows XP, where (IIRC) Unicode was a little shaky at first. We'd want to make sure Windows Installer (the MSI runner) doesn't refuse to try Unicode on XP or anything. So, my suggested course of action would be:
|
@peterflynn With the investigation done and a good plan to move forward I went ahead and removed the sprint milestone for this bug. We have a number of higher priority tasks and potentially will be able to leverage release engineering resources for these type of bugs some time soon. However I keep it assigned to you for now. |
Details TBD @peterflynn
The text was updated successfully, but these errors were encountered: