Quitting multiple times overlays multiple dialogs

[peterflynn]

This problem existed in Sprint 18 too, so it's not caused by the new native menus.

1. Make some unsaved changes
2. Click the window's close button (or on Mac, choose Brackets > Quit)
3. When the unsaved changes dialog appears, repeat step 2 a few times

Result: each quit attempt opens another dialog on top of the old one.
To cancel quitting, you have to cancel all the dialogs in a row. If you choose Save or Don't Save on any one of them, Brackets immediately quits though.

Expected: no additional dialogs appear.

[redmunds]

My expectation is that quit is disabled while you're already in the quit sequence.

[pthiess]

Reviewed

[peterflynn]

@redmunds: we might be able to disable the menu item, but I doubt we can disable the window's close button. So we still need to handle gracefully the scenario where the native app gets a second quit request.

[WebsiteDeveloper]

@peterflynn this does not seem to happen anymore.
Can you confirm?

[lkcampbell]

I don't see this happening on my Mac either. FBNC to @peterflynn.

[peterflynn]

Confirmed -- sorry about the delay. I assume this is because we now block all shell-to-JS command dispatching while a modal dialog is open.