This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Don't execute commands from the shell when a modal dialog is open. #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
reviewing |
|
This looks good on Win7. On Mac 10.8, I can still execute commands in the Brackets menu, such as Quit and the Hide commands. Is that OK? |
|
That seems fine with me. Anyone else have objections? |
|
The Mac issue was true in previous builds as well, since that native menu already existed. |
|
Merging. |
redmunds
added a commit
that referenced
this pull request
Jan 19, 2013
Don't execute commands from the shell when a modal dialog is open.
|
I filed #2619 for the pre-existing bug with Quit being enabled while a quit dialog is already open. (It's not specific to menus either -- can also repro with the window close widget). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary quick fix for #2616
If a modal HTML dialog is open, don't execute commands that originate from the shell. The proper long-term solution is actually disabling command when a modal dialog is open, but that is a much bigger effort that should be a user story.