Don't do auto-close in comments

[njx]

1. Turn on Edit > Auto Close Braces
2. In a JS file, type // TODO: don't do this

Result: The ' is auto-closed, so you get an extra apostrophe.
Expected: Shouldn't auto-close in comments, at least for single-quotes. (Double quotes and parens/braces/brackets are arguably still useful, but you could argue that we should turn off all auto-closing in comments anyway.)

[njx]

Reviewed, low priority.

[albertxing]

I'm currently working on this issue, and I'm wondering whether changes to third-party addon scripts (e.g. src/thirdparty/CodeMirror2/addon/edit/closebrackets.js) allowed?

Additionally, I've noticed that the extension automatch-pairs interferes with the fix because it auto-closes braces independently of CodeMirror. Is there anything we are going to do/willing to do about this?

[TomMalbran]

If you want to change something in CodeMirror, you need to submit a pull request to the CodeMirror project: https://github.com/marijnh/CodeMirror. The submodule in Brackets is updated regularly, so the changed there land in Brackets soon enough.

That extension was done before this feature was added to the core, so it might not be needed anymore.

[albertxing]

Change merged into codemirror/codemirror5@c1b7ea4, needs submodule update.

[albertxing]

Submodule updated, and the new code should now be in Brackets. If everything works, the issue can be closed.

[njx]

FBNC to me. Marking sprint 23 just so I remember to regress it soon :)

[njx]

Confirmed, closing.