Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

HtmlUtils getTagInfo() should return a tag when inside the closing tag #3407

Closed
WebsiteDeveloper opened this issue Apr 10, 2013 · 6 comments
Closed
Assignees
Milestone

Comments

@WebsiteDeveloper
Copy link
Contributor

I spotted this while working on the HtmlEntityHinting.
It currently relies on getTagInfo().tagName to know whether the cursor is within an html tag or not.
HtmlUtils doesn't return a tagName, for example when in an "" closing tag.

@RaymondLim
Copy link
Contributor

HtmlUtils getTagInfo() was originally written for Quick Edit feature and it does not want to allow users to do quick editting with the close tag. So we do have code that explicitly returns an empty tag info for a closing tag.

@WebsiteDeveloper
Copy link
Contributor Author

then maybe something else should be added like a property which is true when it is a closing tag so extensions or other parts of the code can first check if the tag name is not empty and additionally if it is empty the could check if it is a closing tag.
By the way i think i heard someone requesting quick edit also on the closing tag.

@RaymondLim
Copy link
Contributor

Yes, it is #1570.

@ghost ghost assigned RaymondLim Apr 11, 2013
@RaymondLim
Copy link
Contributor

Nominating this for sprint 24. Currently, you can get entity hinting in any closing tag due to this issue.

@njx
Copy link
Contributor

njx commented Apr 18, 2013

Reviewed. Low pri, fix already in progress by @RaymondLim

@RaymondLim
Copy link
Contributor

Fix confirmed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants