[brackets-shell] Windows: Build dependency problem with node-core

[redmunds]

When building brackets-shell in Visual Studio, the executable always thinks it's out-of-date. I'm seeing the following console messages. These are for Debug, but I'm seeing same for Release:

1>------ Build started: Project: Brackets, Configuration: Debug Win32 ------
1>  Copying appshell/node-core/ to ../Debug\\
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\BaseDomain.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\BaseDomain.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\ConnectionManager.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\ConnectionManager.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\DomainManager.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\DomainManager.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\Launcher.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\Launcher.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\Logger.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\Logger.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\package.json -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\package.json
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\README.md -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\README.md
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\Server.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\Server.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\index.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\index.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\package.json -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\package.json
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\README.md -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\README.md
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\lib\browser.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\lib\browser.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\lib\BufferPool.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\lib\BufferPool.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\lib\BufferUtil.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\lib\BufferUtil.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\lib\ErrorCodes.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\lib\ErrorCodes.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\lib\options.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\lib\options.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\lib\Receiver.hixie.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\lib\Receiver.hixie.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\lib\Receiver.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\lib\Receiver.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\lib\Sender.hixie.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\lib\Sender.hixie.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\lib\Sender.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\lib\Sender.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\lib\Validation.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\lib\Validation.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\lib\WebSocket.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\lib\WebSocket.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\node_modules\ws-deploy\lib\WebSocketServer.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\node_modules\ws-deploy\lib\WebSocketServer.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\index.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\index.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\package.json -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\package.json
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\README.md -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\README.md
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\lib\browser.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\lib\browser.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\lib\BufferPool.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\lib\BufferPool.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\lib\BufferUtil.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\lib\BufferUtil.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\lib\ErrorCodes.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\lib\ErrorCodes.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\lib\options.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\lib\options.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\lib\Receiver.hixie.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\lib\Receiver.hixie.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\lib\Receiver.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\lib\Receiver.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\lib\Sender.hixie.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\lib\Sender.hixie.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\lib\Sender.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\lib\Sender.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\lib\Validation.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\lib\Validation.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\lib\WebSocket.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\lib\WebSocket.js
1>  C:\Users\redmunds\github\brackets-shell\appshell\node-core\thirdparty\ws\lib\WebSocketServer.js -> C:\Users\redmunds\github\brackets-shell\Debug\node-core\thirdparty\ws\lib\WebSocketServer.js
1>  38 File(s) copied
========== Build: 1 succeeded, 0 failed, 1 up-to-date, 0 skipped ==========

[jasonsanjose]

Reviewed. Assigned to @joelrbrandt.

[joelrbrandt]

I'm not sure how to address this, but I'll certainly try to do so in my infinite spare time.

The build log that Randy includes suggests another problem: it looks like "ws" is getting included twice. I'm not sure why "ws-deploy" is still in the node_modules folder. We moved it to the thirdparty/ws directory well before we merged in to master.

@redmunds Do you still experience this problem if you do a completely clean clone of the repo and then build from master?

[joelrbrandt]

Since the duplicate "ws" library in the build has nothing to do with this bug, I filed a separate bug: #4189. That bug should be easier to address, and is probably a little more important.

[redmunds]

@joelrbrandt I deleted my brackets-shell branch, rebuilt it from scratch, and I'm seeing the same problem. I am not convinced that #4189 is unrelated, so we should get that resolved before spending any more time on this.

[joelrbrandt]

@redmunds did you actually delete the "appshell/node-core/node_modules" directory on your filesystem? Since node_modules folders are in .gitignore, changing (or removing) branches won't delete those folders.

[redmunds]

@joelrbrandt Sorry, I meant to say that I deleted my entire brackets-shell repo (not branch), so, yes, I did delete the entire appshell directory.