Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Core][Untitled files][Win only]: Incorrect sort order for untitled files. #4409

Closed
julieyuan opened this issue Jul 10, 2013 · 8 comments
Closed
Assignees
Milestone

Comments

@julieyuan
Copy link

Steps:

  1. Launch Brackets.
  2. New several untitled files under the same folder.

Result:
The sort order for these untitled files is different with OS sort order. On Brackets, its files order is: Untitled-1.js,Untitled-2.js,Untitled-3.js, Untitled.js, but its untitled folders order is : Untitled,Untitled-1,Untitled-2,Untitled-3. And OS sort order is: Untitled.js, Untitled-1.js,Untitled-2.js,Untitled-3.js.

Expected:
The sort order for untitled files should follow OS sort oder and untitled folders order.

ENV: Win7x64 ENU
Build: 0.27.0.8255

Notes:
On Mac, its sort order for untitled files is same with Win: Untitled-1.js,Untitled-2.js,Untitled-3.js, Untitled.js. But its OS sort order has same behavior. I think maybe MAC and Win follows different sort order rules.

Snapshots:
Please refer to snapshot for details:
incorrect sort by name

@peterflynn
Copy link
Member

Reviewed - related to #4332. Move both to backlog.

@RaymondLim
Copy link
Contributor

FBNC to @julieyuan

@ghost ghost assigned julieyuan Jul 18, 2013
@julieyuan
Copy link
Author

@RaymondLim I checked this issue in build 0.28.0.8416. Pull request #4463 indeed fixed issue #4332. But another issue occurs. Please refer to snapshot:
7-19-2013 3-56-05 pm

This issue also reproduces on MAC. Untitled-25.js is between Untitled-2.js and Untitled-3.js. I don't think it is right behavior. Please help to fix it .Thanks.

@RaymondLim
Copy link
Contributor

@TomMalbran

Looks like we need another sorting when filenames end with numbers. Do you want to try it by breaking up the trailing numbers and do a secondary sorting if the filenames w/o trailing numbers are the same? Otherwise, we may have to close this one as "move to backlog."

@TomMalbran
Copy link
Contributor

Yes. But I can work on it next week probably.

@RaymondLim
Copy link
Contributor

Thanks. If you can get it done by next Tuesday, then we can keep the milestone. Otherwise, I have to move it out to next sprint.

RaymondLim added a commit that referenced this issue Jul 22, 2013
Issue #4409: Incorrect sort order for untitled files
@RaymondLim
Copy link
Contributor

FBNC to @julieyuan again. You can verify the remaining issue with b8496.

@julieyuan
Copy link
Author

Thanks. It is fixed in build 0.28.0.8496. Here is the snapshot:
bug fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants