Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Core][Invalid filename]: Parameter "{0}" appears in the invalid filename title. #4453

Closed
julieyuan opened this issue Jul 15, 2013 · 9 comments
Assignees
Labels
Milestone

Comments

@julieyuan
Copy link

Steps:

  1. Launch Brackets.
  2. New a file or folder.
  3. Then rename this file with invalid charcters, such as : ??//

Results:
It pops up invalid filename dialog. But there is code "{o}" in this dialog title.

Expects:
This parameter "{0}" should be replaced by string "file" or "directory".

ENV: Mac 10.7.5 English OS
Build: 0.28.0.8326

Snapshots:
Please refer to snapshot for details:
screen shot 2013-07-14 at 10 33 01 pm

@JeffryBooher
Copy link
Contributor

High priority. Recent regression and this looks bad

@ghost ghost assigned JeffryBooher Jul 15, 2013
@njx
Copy link
Contributor

njx commented Jul 15, 2013

Reviewed. Bumping down to medium priority - we generally reserve high priority for crash/hang/data loss. I agree that we should fix it in this sprint though.

@njx
Copy link
Contributor

njx commented Jul 15, 2013

Also, when adding a bug to the current sprint that isn't related to a current story (i.e., it was introduced in a previous sprint), please add it to the bug card in Trello. (I went ahead and added this one.) Thanks.

@JeffryBooher
Copy link
Contributor

@njx I marked this high priority because it was introduced in the last sprint. Should we not mark regressions a high priority? Just trying to understand the triage process :) It totally makes sense that this has no functional impact but the fact that it was a recent injection swayed me to up the priority.

@njx
Copy link
Contributor

njx commented Jul 15, 2013

Hey - we don't assign priority based on whether it's a regression or not - the priority is about user impact.

@JeffryBooher
Copy link
Contributor

Assigning to @TomMalbran. Thanks for the easy fix.

jasonsanjose added a commit that referenced this issue Jul 17, 2013
Issue #4453: Parameter "{0}" appears in the invalid filename title.
@ghost ghost assigned julieyuan Jul 17, 2013
@jasonsanjose
Copy link
Member

FBNC @julieyuan

@julieyuan
Copy link
Author

Thanks. I checked in build 0.28.0-8376 and not fixed yet in this build. I will check it in tomorrow's build again.

@julieyuan
Copy link
Author

It is fixed in build 0.28.0.8416. So closed it. Please refer to snapshot for details:
screen shot 2013-07-18 at 7 38 39 pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants