Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Project tree breaks if filenames contain unusual chars #5080

Closed
peterflynn opened this issue Sep 5, 2013 · 3 comments · Fixed by #5224
Closed

Project tree breaks if filenames contain unusual chars #5080

peterflynn opened this issue Sep 5, 2013 · 3 comments · Fixed by #5224
Assignees
@JeffryBooher
Labels
fixed but not closed
Milestone
Sprint 32

Comments

@peterflynn
Copy link
Member

  1. Right-click a folder > New File
  2. Type foo.(
  3. Press Enter

Result:
Uncaught SyntaxError: Invalid regular expression: /.($/: Unterminated group
in FileUtils._getFilenameWithoutExtension(), called via the jsTree sort callback in ProjectManager._renderTree().

If you repeat step 1, nothing happens -- the tree widget is basically non-functioning.

Expected:
No error, since it's a valid filename.
@peterflynn
Copy link
Member Author

I think this will be fixed by #4846 assuming the code review advice about not using regexp is followed. Assigning to @JeffryBooher since he owns that code review.

@ghost ghost assigned JeffryBooher Sep 5, 2013
@JeffryBooher JeffryBooher mentioned this issue Sep 16, 2013
Merged
@JeffryBooher JeffryBooher reopened this Sep 16, 2013
@JeffryBooher
Copy link
Contributor

Indeed. This appears to be fixed with #5224

@peterflynn
Copy link
Member Author

Confirmed fixed now that it's merged

@core-ai-bot core-ai-bot mentioned this issue Aug 29, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JeffryBooher JeffryBooher

Labels
fixed but not closed
Projects
None yet
Milestone
Sprint 32
Development

Successfully merging a pull request may close this issue.

Clean up _getFileExtension() method and fix all its callers adobe/brackets
2 participants
@peterflynn @JeffryBooher