This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Clean up _getFileExtension() method and fix all its callers #5224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JeffryBooher
commented
Sep 16, 2013
JeffryBooher
commented
- Addresses final comments from code review for Clean up _getFileExtension() method and fix all its callers #4846
- Fixes FileUtils contains two different 'get file extension' functions #4575
- Fixes Project tree breaks if filenames contain unusual chars #5080
ghost
assigned 
|
Assigning this @peterflynn to do the merge |
This was referenced Sep 16, 2013
|
Looks good, thanks all! |
peterflynn
added a commit
that referenced
this pull request
Sep 27, 2013
Clean up _getFileExtension() method and fix all its callers
Closed
This was referenced Aug 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.