Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Tag highlighting sometimes highlights comments #5194

Closed
peterflynn opened this issue Sep 13, 2013 · 5 comments
Closed

Tag highlighting sometimes highlights comments #5194

peterflynn opened this issue Sep 13, 2013 · 5 comments

Comments

@peterflynn
Copy link
Member

  1. Open Brackets' main index.html
  2. Put cursor on line 66, at end of -->
  3. Press enter
  4. Type <div> (which auto-inserts </div> after the cursor)
  5. Undo twice

Result: The two comment blocks before & after the cursor are highlighted with a gray background.

When you put your cursor in the same place in step 2, there was no highlight.

@ghost ghost assigned RaymondLim Sep 16, 2013
@njx
Copy link
Contributor

njx commented Sep 16, 2013

Low priority to @RaymondLim

@RaymondLim
Copy link
Contributor

I can reproduce it in the CodeMirror demo page and log a tracking issue codemirror/codemirror5#1841.

@RaymondLim
Copy link
Contributor

Marijn already fixed the issue, but his fix also introduced some unit test failures in Brackets. So when we merge upstream for sprint 33, we also need to make some changes in HTMLUtils.js to recognize the new token type tag error that he introduced in his fix.

@RaymondLim
Copy link
Contributor

FBNC to @peterflynn

@ghost ghost assigned peterflynn Oct 15, 2013
@peterflynn
Copy link
Member Author

Confirmed fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants