Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Jasmine] No locale strings used #5431

Closed
marcelgerber opened this issue Oct 5, 2013 · 3 comments
Closed

[Jasmine] No locale strings used #5431

marcelgerber opened this issue Oct 5, 2013 · 3 comments
Milestone
Sprint 33

Comments

@marcelgerber
Copy link
Contributor

I just ran all Jasmine tests while brackets was set to german, and I got four error messages on Install Extension dialog (example: Error: Expected 'Überschreiben' to equal 'Overwrite'.).
I afterwards checked if the correct strings are loaded (alert(Strings.OVERWRITE);), but within Jasmine every time the english (root) ones are loaded. So this test only runs smooth if the lang is set to english.

There are three tests that require strings (ExtensionManager, InstallExtensionDialog, LiveDevelopment), but it affects only this one.
@WebsiteDeveloper WebsiteDeveloper mentioned this issue Oct 5, 2013
Merged
@redmunds
Copy link
Contributor

redmunds commented Oct 9, 2013

Nominating for Sprint 33.

@marcelgerber
Copy link
Contributor Author

The fix offered by @WebsiteDeveloper works fine.

couzteau added a commit that referenced this issue Oct 12, 2013
@couzteau
Merge pull request #5433 from WebsiteDeveloper/Issue-5431
a9bed36 
Issue: #5431 Fix Tests for non English locales
@couzteau
Copy link
Member

Merged fix #5433

@core-ai-bot core-ai-bot mentioned this issue Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 33
Development

No branches or pull requests
3 participants
@couzteau @redmunds @marcelgerber