Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Initialized fonts dom element ASAP instead of waiting for appinit #8525

Closed
wants to merge 1 commit into from
Closed

Initialized fonts dom element ASAP instead of waiting for appinit #8525

wants to merge 1 commit into from

Conversation

MiguelCastillo
Copy link
Contributor

@MiguelCastillo MiguelCastillo mentioned this pull request Jul 23, 2014
Closed
@redmunds
Copy link
Contributor

@MiguelCastillo @peterflynn The bug referenced in the description (#8524) is High Priority, Milestone 0.42, & FBNC. Is this still a valid fix? If so, do we want to get this in for Release 0.42?

@MiguelCastillo
Copy link
Contributor Author

@redmunds This PR addresses the underlying issue that is exposed when adding line-heights. Since line-height is no longer in the code, the issue is no longer visible. However, the code in this PR is "more correct" but I don't think is worth adding it to 42 as there is no apparent side effect we can find. I think we can merge this in 43.

@MiguelCastillo
Copy link
Contributor Author

@redmunds The code in this PR is so outdated, I couldn't get a nice clean merge going. I am going to create a new one...

@MiguelCastillo MiguelCastillo deleted the fonts-8524 branch August 4, 2014 00:46
@core-ai-bot core-ai-bot mentioned this pull request Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MiguelCastillo @redmunds