Redirect to friendly error page if brackets/index.html can't be found #890
Comments
|
Although this is native work, I think we should consider it for Sprint 10 since it's a common usability pitfall for the initial download/"install" experience. If we have a spike in interest in the near future, this would be a valuable fix to get in. |
|
I think the "brackets/index.html can't be found" issue is caused by Brackets auto-loading the last opened folder, in this case the src folder. Would a better fix be to prompt to open a new or existing folder if the last folder is no longer existing? |
|
@tomByrer -- this is actually about the Brackets shell not being able to open the app itself (not opening the last opened folder once it's already running). |
ghost
assigned
|
Ah yes, you are correct @njx since Brackets first opened the source file, I assumed incorrectly that Brackets did not need the /src folder. I find it strange for a program to need the "src", since 99% of the programs I installed only need the /bin to run, & /src is provided only if you wanted to compile yourself. |
|
Yes, this is all temporary until we have a build process. Eventually the HTML source for the app will be copied into the binary package (on Mac) or installed into some appropriate application data folder on Windows. |
|
Fixed in brackets-app. @peterflynn - you logged the original bug in brackets-app; would you mind regressing? You can test by copying Brackets.exe/Brackets.app to a different directory or by renaming the brackets folder. |
|
Verified on Win. Just need to regress on Mac once I'm in the office tomorrow. |
|
Confirmed on Mac too |
Fix mozilla/thimble.mozilla.org#2506 * Added all components for Border Radius Inline editor * remove text selection after closing inline border radius editor * made allCornerSlider and individual slider work seperately without effecting each other * added the slider value indicator * modified BorderRadiusEditor to allow keeping all units(%,em,px) * modified BorderRadiusEditor to allow keeping all units(%,em,px)--#2 * added radio buttons to toggle slider unit * making individual corner values sync with allcorner mode value * Border UI updates * fixed when close inlineEditor the cursor do not go to top * Light theme + CSS cleanup * code cleaned up * fixed indentation and replaceAll() local function * fixed some indentations * removed _values local property from borderRadiusEditor.js * Fixed few indentations and comments * added comment for borderRadiusUtil * added more comments in borderRadiusUtils.js * Fixed few comments * Review fixes * Fixed some codes according to comments from gide * fixed indentation * fixed indentation 2x
Currently, if people are missing the brackets submodule, launching brackets-app displays an unhelpful "error -1" message giving no clue as to what's wrong. The app shell should redirect to a friendlier error message HTML page in this case.
a) The page should say what the problem is (e.g. "unable to find index.html in the brackets submodule").
b) It should also offer advice for the two most likely causes of this:
git submodule update --init --recursiveto pull down the submodules.Moved from Native App Shell issues adobe/brackets-app#122. (already reviewed)
The text was updated successfully, but these errors were encountered: