Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Releases broken, don't include submodules #9068

Closed
jgillich opened this issue Sep 11, 2014 · 5 comments
Closed

Releases broken, don't include submodules #9068

jgillich opened this issue Sep 11, 2014 · 5 comments

Comments

@jgillich
Copy link

The source code releases on GitHub don't include submodules (like src/thirdparty/path-utils and others), thus they don't build.

@redmunds
Copy link
Contributor

@jgillich Release names are also a tag in the brackets repo, so instead you can checkout the code there. For example, to checkout Release 0.43:

git checkout release-0.43
git submodule update --init

Does that solve your issue?

@peterflynn
Copy link
Member

@jgillich Are you talking about the "Download ZIP" button on https://github.com/adobe/brackets and/or the "Source code (zip)" buttons listed on https://github.com/adobe/brackets/releases? Unfortunately that's a GitHub bug -- submodules are always left out. We don't control the downloads those buttons link to, and we can't even turn them off. We pinged GitHub support about this over a year ago and they haven't fixed it :-/

Closing since there's nothing else we can really do about this...

@jgillich
Copy link
Author

I'm talking about the releases page. I realize that GitHub doesn't include submodules, but since you've managed to upload the various packages/installers, couldn't you just upload a tarball of the source that includes the submodules?

I'm asking because I work on building a rpm package and it is much better to put a URL to a tarball in the spec file instead of doing a manual checkout from git. IMHO, there should always be a way to download the source without using a SCM.

@redmunds
Copy link
Contributor

@jgillich You are welcome to create and post tarballs for each release as a service to the Brackets Linux Community. Let us know so we can post links to your site.

@Viterbo
Copy link

Viterbo commented Jul 28, 2015

The following bash command sequence worked for me:

git clone https://github.com/adobe/brackets.git
cd brackets
git submodule update --init
sed -i "s/'jasmine',/\/\/'jasmine' ,/g" ./Gruntfile.js
npm install
grunt build

Keep in mind that this solution removes the 'jasmine' task to avoid the problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@jgillich @redmunds @peterflynn @Viterbo and others