Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

quick edit function doesn't work and it crashes #9942

Closed
ugurkoban opened this issue Nov 16, 2014 · 10 comments
Closed

quick edit function doesn't work and it crashes #9942

ugurkoban opened this issue Nov 16, 2014 · 10 comments

Comments

@ugurkoban
Copy link

quick edit function doesn't work. i use win 7 64 bit and also in my company i use 8.1 64bit. it also doesnt work. but in edge code it works!

and always it crashes, example: debug>developer tools F12

printscreen added
4
3
2
1
5
6
7

@RaymondLim
Copy link
Contributor

@ugurkoban It seems like you're seeing a similar issue as #9840. Since you're having a crash too, can you post your css file content?

@ugurkoban
Copy link
Author

it is not only with this css but also for all my websites (i tried about
more than ten) that i included to bracklets.

i attached my css js and html files.

2014-11-16 20:06 GMT+02:00 Raymond Lim notifications@github.com:

@ugurkoban https://github.com/ugurkoban It seems like you're seeing a
similar issue as #9840 #9840.
Since you're having a crash too, can you post your css file content?


Reply to this email directly or view it on GitHub
#9942 (comment).

@RaymondLim
Copy link
Contributor

@ugurkoban I didn't see your attachments. Are you posting as GitHub gist files? If so, can you paste the links in a comment?

@ugurkoban
Copy link
Author

https://www.wetransfer.com/downloads/7d1f5cdb862d09b242c8437a47606fee20141116214301/991a208a2084f15944cdfe7f431a871b20141116214301/78ff6e

2014-11-16 22:24 GMT+02:00 Raymond Lim notifications@github.com:

@ugurkoban https://github.com/ugurkoban I didn't see your attachments.
Are you posting as GitHub gist files? If so, can you paste the links in a
comment.


Reply to this email directly or view it on GitHub
#9942 (comment).

@RaymondLim RaymondLim added this to the Release 1.1 milestone Nov 16, 2014
@RaymondLim RaymondLim self-assigned this Nov 16, 2014
@RaymondLim
Copy link
Contributor

Thanks @ugurkoban

I confirmed that it is caused by the following minimized block at the beginning of your style.css file and I can reproduce the issue on Windows only. Still I cannot make it crash though.

html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{margin:0;padding:0;border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent}body{line-height:1}ol,ul{list-style:none}blockquote,q{quotes:none}blockquote:before,blockquote:after,q:before,q:after{content:'';content:none}:focus{outline:0}ins{text-decoration:none}del{text-decoration:line-through}table{border-collapse:collapse;border-spacing:0}

Update: I can get a crash only after closing developer tools. I also narrow it down the culprit code to :focus{...}. So it has the same root cause as #9840.

@RaymondLim
Copy link
Contributor

Remove Win only label since I was testing on my mac with my fix for #9840. Otherwise, it can also be reproduced on Mac.

@RaymondLim
Copy link
Contributor

Closing as a dupe of #9840 since both of them are caused by a rule starting with a pseudo selector.

@ugurkoban
Copy link
Author

i deleted code and quick edit works but whatever i open even a blank html page when i press developer tool F12 when closing the page it crashes. is this another bug or what? thanks

@RaymondLim
Copy link
Contributor

@ugurkoban The crash may be a separate issue. I'll try later and reopen it if I can repro the crash.

@peterflynn
Copy link
Member

Crash after closing developer tools (only on Windows) is already filed: #9011. Likely to be a CEF bug. The workaround is just to leave dev tools open until you quit Brackets.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants