Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Preferences validation dialog is not given focus, so document is editable #9975

Closed
redmunds opened this issue Nov 19, 2014 · 2 comments · Fixed by #10022
Closed

Preferences validation dialog is not given focus, so document is editable #9975

redmunds opened this issue Nov 19, 2014 · 2 comments · Fixed by #10022
Assignees
@busykai
Labels
F Preferences low priority
Milestone
Release 1.1

Comments

@redmunds
Copy link
Contributor

Recipe

  1. Debug > Open Preferences File
  2. Edit a defined preference to have an invalid value, such as:
"tabSize": { line: 0, ch: 0 },
  1. Important: leave focus in editor
  2. Ctrl+S (to save file) and F5 (to Reload Brackets)

Result
Modal Error Reading Preferences dialog is displayed, but focus is still in document and it's editable!

Expected
Dialog creates the illusion of modality. You can see this by clicking on dialog (without dismissing it) -- focus cannot be returned to document at this point.
@busykai busykai self-assigned this Nov 20, 2014
@busykai
Copy link
Contributor

busykai commented Nov 20, 2014

@redmunds i'll take this one. added that dialog in the first place.

busykai added a commit that referenced this issue Nov 26, 2014
@busykai
Fix #9975.
9afe56c
@busykai busykai mentioned this issue Nov 26, 2014
Merged
redmunds added a commit that referenced this issue Dec 2, 2014
@redmunds
Merge pull request #10022 from adobe/kai/fix-9975-modal-dialog-is-not…
e0c0b98 
…-modal

Fix #9975.
@redmunds redmunds added this to the Release 1.1 milestone Dec 2, 2014
@redmunds
Copy link
Contributor Author

redmunds commented Dec 2, 2014

Confirmed. Closing.

@core-ai-bot core-ai-bot mentioned this issue Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@busykai busykai

Labels
F Preferences low priority
Projects
None yet
Milestone
Release 1.1
Development

Successfully merging a pull request may close this issue.

Fix #9975. adobe/brackets
3 participants
@redmunds @peterflynn @busykai