This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Handle undefined theme the right way #10243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,7 +41,7 @@ define(function (require, exports, module) { | |||
| var loadedThemes = {}, | |||
| currentTheme = null, | |||
| styleNode = $(ExtensionUtils.addEmbeddedStyleSheet("")), | |||
| defaultTheme = "thor-light-theme", | |||
| defaultTheme = "light-theme", | |||
There was a problem hiding this comment.
This has never caused any issues, has it?
cc @MiguelCastillo
There was a problem hiding this comment.
@marcelgerber no we haven't ran into issues. That's because we have this https://github.com/adobe/brackets/blob/master/src/view/ThemeSettings.js#L49.
That discrepancy was introduced in the shuffling when we were trying to land themes. I have cleaned up lots of that stuff in this PR #9069 which I think we should really merge, but have not heard much feedback on.
There was a problem hiding this comment.
Ah, reverted the change in this PR (as it's not necessary) to not cause any unnecessary conflicts with your PR.
marcelgerber
force-pushed
the
theme-undefined
branch
from
a82cab1
to
e906f1a
Compare
|
@MiguelCastillo Feel free to merge this :) |
MiguelCastillo
added a commit
that referenced
this pull request
Dec 20, 2014
Handle undefined theme the right way
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the confusion.
This is the right way to do #10236.