New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Spell Checking #10321

Merged
merged 1 commit into from Apr 7, 2015

Conversation

Projects
None yet
5 participants
@MarcelGerber
Contributor

MarcelGerber commented Jan 6, 2015

For #10241

@@ -22,7 +22,7 @@
DEALINGS IN THE SOFTWARE.
-->
<html>
<html spellcheck="false">

This comment has been minimized.

@redmunds

redmunds Jan 6, 2015

Contributor

Ick. Any way to fix this in CSS?

@redmunds

redmunds Jan 6, 2015

Contributor

Ick. Any way to fix this in CSS?

This comment has been minimized.

@RaymondLim

RaymondLim Jan 6, 2015

Contributor

This link has a way to do it in JavaScript.

@RaymondLim

RaymondLim Jan 6, 2015

Contributor

This link has a way to do it in JavaScript.

This comment has been minimized.

@MarcelGerber

MarcelGerber Jan 6, 2015

Contributor

@RaymondLim Your solution works only for static pages, where all input/textarea fields are already existent on pageload.

@MarcelGerber

MarcelGerber Jan 6, 2015

Contributor

@RaymondLim Your solution works only for static pages, where all input/textarea fields are already existent on pageload.

This comment has been minimized.

@redmunds

redmunds Jan 6, 2015

Contributor

I think @RaymondLim was suggesting to use that technique to apply spellcheck="false" to the html tag so it's not hard-coded in index.html. Probably only need to apply it to the body tag.

@redmunds

redmunds Jan 6, 2015

Contributor

I think @RaymondLim was suggesting to use that technique to apply spellcheck="false" to the html tag so it's not hard-coded in index.html. Probably only need to apply it to the body tag.

This comment has been minimized.

@peterflynn

peterflynn Jan 7, 2015

Member

@redmunds I think it's actually nicer to do keep it in the declarative markup. Why do it in JS if there's nothing dynamic about it?

@peterflynn

peterflynn Jan 7, 2015

Member

@redmunds I think it's actually nicer to do keep it in the declarative markup. Why do it in JS if there's nothing dynamic about it?

This comment has been minimized.

@redmunds

redmunds Jan 7, 2015

Contributor

This is a CEF-only issue, so it doesn't apply to other configurations (e.g. in-browser). I also would rather not clutter the HTML markup.

@redmunds

redmunds Jan 7, 2015

Contributor

This is a CEF-only issue, so it doesn't apply to other configurations (e.g. in-browser). I also would rather not clutter the HTML markup.

This comment has been minimized.

@peterflynn

peterflynn Jan 7, 2015

Member

@redmunds It's not CEF specific afaik -- spell checking is a feature in most modern browsers, we just didn't see it before since our version of Chromium was so old :-/ I see the same behavior when running Brackets in-browser in Chrome, and presumably Safari & FF at least would be the same.

@peterflynn

peterflynn Jan 7, 2015

Member

@redmunds It's not CEF specific afaik -- spell checking is a feature in most modern browsers, we just didn't see it before since our version of Chromium was so old :-/ I see the same behavior when running Brackets in-browser in Chrome, and presumably Safari & FF at least would be the same.

@nethip

This comment has been minimized.

Show comment
Hide comment
@nethip

nethip Apr 3, 2015

Contributor

I feel this is fine to leave the spellcheck in the markup. @redmunds Do you think this is fine or you suggest we go the JS way of solving this issue.

This would be good candidate for 1.3.

Contributor

nethip commented Apr 3, 2015

I feel this is fine to leave the spellcheck in the markup. @redmunds Do you think this is fine or you suggest we go the JS way of solving this issue.

This would be good candidate for 1.3.

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Apr 3, 2015

Contributor

@nethip This is pretty ugly, so I agree this fix should be merged for 1.3.

Contributor

redmunds commented Apr 3, 2015

@nethip This is pretty ugly, so I agree this fix should be merged for 1.3.

nethip added a commit that referenced this pull request Apr 7, 2015

@nethip nethip merged commit 77e5509 into adobe:master Apr 7, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@nethip

This comment has been minimized.

Show comment
Hide comment
@nethip

nethip Apr 7, 2015

Contributor

Thanks @MarcelGerber

Contributor

nethip commented Apr 7, 2015

Thanks @MarcelGerber

@MarcelGerber MarcelGerber deleted the MarcelGerber:disable-spell-check branch Apr 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment