Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Disable Spell Checking #10321

Merged
merged 1 commit into from
Apr 7, 2015
Merged

Conversation

marcelgerber
Copy link
Contributor

For #10241

@@ -22,7 +22,7 @@
DEALINGS IN THE SOFTWARE.
-->

<html>
<html spellcheck="false">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ick. Any way to fix this in CSS?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link has a way to do it in JavaScript.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLim Your solution works only for static pages, where all input/textarea fields are already existent on pageload.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @RaymondLim was suggesting to use that technique to apply spellcheck="false" to the html tag so it's not hard-coded in index.html. Probably only need to apply it to the body tag.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@redmunds I think it's actually nicer to do keep it in the declarative markup. Why do it in JS if there's nothing dynamic about it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a CEF-only issue, so it doesn't apply to other configurations (e.g. in-browser). I also would rather not clutter the HTML markup.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@redmunds It's not CEF specific afaik -- spell checking is a feature in most modern browsers, we just didn't see it before since our version of Chromium was so old :-/ I see the same behavior when running Brackets in-browser in Chrome, and presumably Safari & FF at least would be the same.

@nethip
Copy link
Contributor

nethip commented Apr 3, 2015

I feel this is fine to leave the spellcheck in the markup. @redmunds Do you think this is fine or you suggest we go the JS way of solving this issue.

This would be good candidate for 1.3.

@redmunds
Copy link
Contributor

redmunds commented Apr 3, 2015

@nethip This is pretty ugly, so I agree this fix should be merged for 1.3.

nethip added a commit that referenced this pull request Apr 7, 2015
@nethip nethip merged commit 77e5509 into adobe:master Apr 7, 2015
@nethip
Copy link
Contributor

nethip commented Apr 7, 2015

Thanks @marcelgerber

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants