Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Update for Serbian translation #10350

Merged
merged 2 commits into from
Feb 10, 2015
Merged

Update for Serbian translation #10350

merged 2 commits into from
Feb 10, 2015

Conversation

goranvasic
Copy link
Contributor

Serbian translation was missing translated strings for several menu options and tooltips. These are now covered, and also some previous translations for the UI were modified to be more "user friendly".

Serbian translation was missing translated strings for several menu options and tooltips. These are now covered, and also some previous translations for the UI were modified to be more "user friendly".
@goranvasic
Copy link
Contributor Author

I can see that Travis build failed, so I submitted the contributor license agreement here http://dev.brackets.io/brackets-contributor-license-agreement.html

@RaymondLim
Copy link
Contributor

@goranvasic You have some duplicate keys that are causing some linting errors.

Linting src/nls/sr/strings.js...ERROR
[L131:C41] W075: Duplicate key 'BUTTON_YES'.
    "BUTTON_YES"                        : "Да",
Linting src/nls/sr/strings.js...ERROR
[L132:C41] W075: Duplicate key 'BUTTON_NO'.
    "BUTTON_NO"                         : "Не",
Linting src/nls/sr/strings.js...ERROR
[L348:C44] W075: Duplicate key 'OK'.
    "OK"                                   : "У реду",
Linting src/nls/sr/strings.js...ERROR
[L349:C44] W075: Duplicate key 'DONT_SAVE'.
    "DONT_SAVE"                            : "Немој сачувати",
Linting src/nls/sr/strings.js...ERROR
[L350:C44] W075: Duplicate key 'SAVE'.
    "SAVE"                                 : "Сачувај",
Linting src/nls/sr/strings.js...ERROR
[L351:C44] W075: Duplicate key 'CANCEL'.
    "CANCEL"                               : "Откажи",
Linting src/nls/sr/strings.js...ERROR
[L352:C44] W075: Duplicate key 'DELETE'.
    "DELETE"                               : "Обриши",

@@ -457,3 +518,5 @@ define({
// extensions/default/WebPlatformDocs
"DOCS_MORE_LINK" : "Прочитај више"
});

/* Last translated for 752856d58d2e9dde14e1af6be615bb7080727b7a */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you get this? This is not a valid SHA. You have to look up from this history page and copy the SHA from the one that you're translating for. Make sure you have the exact total line numbers in your localized file when comparing (diffing) to the English strings and also ensure that your localized file does not have keys in a different order from root/strings.js. Once you verify the order and diffing the changes properly, then you will also fix the linting issue from Travis.

Refactored entire Serbian translation strings.js file so that it is in sync with root/strings.js - previously its structure, line numbers and order of the keys were different. Correct SHA for the last commit on root/strings.js has been added to the bottom of the file.
@goranvasic
Copy link
Contributor Author

@RaymondLim Could you please check the Travis CI build, it seems that it was not able to properly execute npm command. Note that I submitted my commit directly from web browser.

@RaymondLim
Copy link
Contributor

@goranvasic Not sure what went wrong with npm, but I restarted the build and it should be fine this time.

@goranvasic
Copy link
Contributor Author

@RaymondLim Thank you.

@goranvasic
Copy link
Contributor Author

@RaymondLim I see that this pull request is still not merged so please let me know if there is anything else that needs to be done on my side.

@RaymondLim
Copy link
Contributor

@goranvasic Do you have someone that can do the linguistic review?

@goranvasic
Copy link
Contributor Author

@frennky can you please review this translation?

@frennky
Copy link

frennky commented Jan 16, 2015

Everything looks good to me.

@goranvasic
Copy link
Contributor Author

@frennky Thanks
@RaymondLim Is this ok to be merged now?

nethip added a commit that referenced this pull request Feb 10, 2015
Update for Serbian translation
@nethip nethip merged commit fe65311 into adobe:master Feb 10, 2015
@goranvasic goranvasic deleted the patch-1 branch February 10, 2015 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants