New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10228] Cmd+Delete now triggers Don't Save in Save Changes dialog #10459

Merged
merged 1 commit into from Mar 3, 2015

Conversation

Projects
None yet
3 participants
@lucaslouca
Contributor

lucaslouca commented Jan 24, 2015

Cmd+Delete (Mac) now triggers Don't Save in Save Changes dialog. This is the system's default behaviour (see http://support.apple.com/en-us/HT201236).

(Issue #10228)

@MarcelGerber

View changes

Show outdated Hide outdated src/widgets/Dialogs.js
@peterflynn

This comment has been minimized.

Show comment
Hide comment
@peterflynn

peterflynn Mar 1, 2015

Member

@lucaslouca It sounds like some Mac apps use Cmd-D also (e.g. #283 mentions this), so this should probably be ||ed with the original check.

Also, could you squash this down to one commit? 3-4 commits for a single-line change makes the git history a little sloppy.

Looks great otherwise though!

Member

peterflynn commented Mar 1, 2015

@lucaslouca It sounds like some Mac apps use Cmd-D also (e.g. #283 mentions this), so this should probably be ||ed with the original check.

Also, could you squash this down to one commit? 3-4 commits for a single-line change makes the git history a little sloppy.

Looks great otherwise though!

@peterflynn

This comment has been minimized.

Show comment
Hide comment
@peterflynn

peterflynn Mar 1, 2015

Member

Ah, I forgot that the existing Cmd-D code has been broken for a long time, due to conflicting with a menubar shortcut (see #4135 / scoped keybindings story). So this actually looks fine as is -- if you can just squash the commits, I think we can go ahead & merge.

Member

peterflynn commented Mar 1, 2015

Ah, I forgot that the existing Cmd-D code has been broken for a long time, due to conflicting with a menubar shortcut (see #4135 / scoped keybindings story). So this actually looks fine as is -- if you can just squash the commits, I think we can go ahead & merge.

[#10228] Cmd+Delete now triggers Don't Save in Save Changes dialog
Fix memory leak in CSS & SVG Code Hints

Clicking an Extension Manager tab while still loading will show it

Use function to clear search

Code review changes

Change font weight of menu items to be 'normal' instead of 200, to improve readability.

Changed comment to apply for CMD+Backspace

[#10228] Cmd+Delete now triggers Don't Save in Save Changes dialog
@lucaslouca

This comment has been minimized.

Show comment
Hide comment
@lucaslouca

lucaslouca Mar 1, 2015

Contributor

Hello,

done :)

On 2015-03-01 09:04, Peter Flynn wrote:

Ah, I forgot that the existing Cmd-D code has been broken for a long
time, due to conflicting with a menubar shortcut (see #4135 [1] /
scoped keybindings story [2]). So this actually looks fine as is -- if
you can just squash the commits, I think we can go ahead & merge.

Reply to this email directly or view it on GitHub [3].

Links:

[1] #4135
[2]
https://trello.com/c/I07x1pO0/1002-more-flexible-context-sensitive-scoped-key-event-handling
[3] #10459 (comment)

Contributor

lucaslouca commented Mar 1, 2015

Hello,

done :)

On 2015-03-01 09:04, Peter Flynn wrote:

Ah, I forgot that the existing Cmd-D code has been broken for a long
time, due to conflicting with a menubar shortcut (see #4135 [1] /
scoped keybindings story [2]). So this actually looks fine as is -- if
you can just squash the commits, I think we can go ahead & merge.

Reply to this email directly or view it on GitHub [3].

Links:

[1] #4135
[2]
https://trello.com/c/I07x1pO0/1002-more-flexible-context-sensitive-scoped-key-event-handling
[3] #10459 (comment)

@peterflynn

This comment has been minimized.

Show comment
Hide comment
@peterflynn

peterflynn Mar 3, 2015

Member

Looks good -- thanks!

Member

peterflynn commented Mar 3, 2015

Looks good -- thanks!

peterflynn added a commit that referenced this pull request Mar 3, 2015

Merge pull request #10459 from lucaslouca/bugfix10228
[#10228] Cmd+Backspace now triggers "Don't Save" dialog button

@peterflynn peterflynn merged commit 55bd215 into adobe:master Mar 3, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment