New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordsmithing on Health Data strings #10833

Merged
merged 2 commits into from Apr 7, 2015

Conversation

Projects
None yet
3 participants
@MarcelGerber
Contributor

MarcelGerber commented Apr 6, 2015

"HEALTH_DATA_DO_TRACK" : "Yes, I would like to share information on how I use the Brackets.",
"HEALTH_DATA_NOTIFICATION_MESSAGE" : "In order to improve Brackets, we periodically send <strong>anonymous</strong> data about how you use the Brackets.",
"HEALTH_DATA_PREVIEW" : "Health Data Preview File",
"HEALTH_DATA_PREVIEW_MESSAGE" : "No Data to Show"

This comment has been minimized.

@MarcelGerber

MarcelGerber Apr 6, 2015

Contributor

This string was never used.

@MarcelGerber

MarcelGerber Apr 6, 2015

Contributor

This string was never used.

* Check if the health data is to be sent to the server. If the user has enabled tracking, health data will be sent once every 24 hours.
* Send health data to the server if the period is more than 24 hours.
* Check if the Health Data is to be sent to the server. If the user has enabled tracking, Health Data will be sent once every 24 hours.
* Send Health Data to the server if the period is more than 24 hours.

This comment has been minimized.

@peterflynn

peterflynn Apr 7, 2015

Member

I don't know if we need to capitalize every place we use the phrase "health data," since it's not the official name of the feature or anything. I could see capitalizing (part of) the phrase "Health Report data" since that matches the user-facing feature name. Not a big deal either way though.

@peterflynn

peterflynn Apr 7, 2015

Member

I don't know if we need to capitalize every place we use the phrase "health data," since it's not the official name of the feature or anything. I could see capitalizing (part of) the phrase "Health Report data" since that matches the user-facing feature name. Not a big deal either way though.

This comment has been minimized.

@MarcelGerber

MarcelGerber Apr 7, 2015

Contributor

Ah, I thought that was the official name, and I wanted to harmonize all the different notations a little.

@MarcelGerber

MarcelGerber Apr 7, 2015

Contributor

Ah, I thought that was the official name, and I wanted to harmonize all the different notations a little.

@peterflynn

This comment has been minimized.

Show comment
Hide comment
@peterflynn

peterflynn Apr 7, 2015

Member

These changes overall look solid to me. @MarcelGerber note that some of them might be overwritten in the near future (e.g. if we remove the ExtensionManager changes that seem unneeded, or when we tweak the UI further). But I don't see why we couldn't merge this and then make those further changes later.

@prafulVaishnav do you want to take a look at this and merge if it seems good to you too?

Member

peterflynn commented Apr 7, 2015

These changes overall look solid to me. @MarcelGerber note that some of them might be overwritten in the near future (e.g. if we remove the ExtensionManager changes that seem unneeded, or when we tweak the UI further). But I don't see why we couldn't merge this and then make those further changes later.

@prafulVaishnav do you want to take a look at this and merge if it seems good to you too?

@prafulVaishnav

This comment has been minimized.

Show comment
Hide comment
@prafulVaishnav

prafulVaishnav Apr 7, 2015

Contributor

@peterflynn Yes, I will take a look and merge it..

Contributor

prafulVaishnav commented Apr 7, 2015

@peterflynn Yes, I will take a look and merge it..

prafulVaishnav added a commit that referenced this pull request Apr 7, 2015

Merge pull request #10833 from MarcelGerber/hd-strings
Wordsmithing on Health Data strings

@prafulVaishnav prafulVaishnav merged commit db0bd43 into adobe:master Apr 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@prafulVaishnav

This comment has been minimized.

Show comment
Hide comment
@prafulVaishnav
Contributor

prafulVaishnav commented Apr 7, 2015

Thanks @MarcelGerber

@MarcelGerber MarcelGerber deleted the MarcelGerber:hd-strings branch Apr 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment