Wordsmithing on Health Data strings #10833
Conversation
| "HEALTH_DATA_DO_TRACK" : "Yes, I would like to share information on how I use the Brackets.", | ||
| "HEALTH_DATA_NOTIFICATION_MESSAGE" : "In order to improve Brackets, we periodically send <strong>anonymous</strong> data about how you use the Brackets.", | ||
| "HEALTH_DATA_PREVIEW" : "Health Data Preview File", | ||
| "HEALTH_DATA_PREVIEW_MESSAGE" : "No Data to Show" |
There was a problem hiding this comment.
This string was never used.
| * Check if the health data is to be sent to the server. If the user has enabled tracking, health data will be sent once every 24 hours. | ||
| * Send health data to the server if the period is more than 24 hours. | ||
| * Check if the Health Data is to be sent to the server. If the user has enabled tracking, Health Data will be sent once every 24 hours. | ||
| * Send Health Data to the server if the period is more than 24 hours. |
There was a problem hiding this comment.
I don't know if we need to capitalize every place we use the phrase "health data," since it's not the official name of the feature or anything. I could see capitalizing (part of) the phrase "Health Report data" since that matches the user-facing feature name. Not a big deal either way though.
There was a problem hiding this comment.
Ah, I thought that was the official name, and I wanted to harmonize all the different notations a little.
|
These changes overall look solid to me. @marcelgerber note that some of them might be overwritten in the near future (e.g. if we remove the ExtensionManager changes that seem unneeded, or when we tweak the UI further). But I don't see why we couldn't merge this and then make those further changes later. @prafulVaishnav do you want to take a look at this and merge if it seems good to you too? |
|
@peterflynn Yes, I will take a look and merge it.. |
Wordsmithing on Health Data strings
|
Thanks @marcelgerber |
cc @nethip @prafulVaishnav