Wordsmithing on Health Data strings #10833

Merged
merged 2 commits into from Apr 7, 2015

Projects

None yet

3 participants

@MarcelGerber MarcelGerber commented on the diff Apr 6, 2015
src/nls/root/strings.js
@@ -623,12 +629,5 @@ define({
"CMD_TOGGLE_RECENT_PROJECTS" : "Recent Projects",
// extensions/default/WebPlatformDocs
- "DOCS_MORE_LINK" : "Read more",
-
- //Health Data
- "HEALTH_DATA_NOTIFICATION" : "HealthData Preferences",
- "HEALTH_DATA_DO_TRACK" : "Yes, I would like to share information on how I use the Brackets.",
- "HEALTH_DATA_NOTIFICATION_MESSAGE" : "In order to improve Brackets, we periodically send <strong>anonymous</strong> data about how you use the Brackets.",
- "HEALTH_DATA_PREVIEW" : "Health Data Preview File",
- "HEALTH_DATA_PREVIEW_MESSAGE" : "No Data to Show"
@MarcelGerber
MarcelGerber Apr 6, 2015 Member

This string was never used.

@peterflynn peterflynn commented on the diff Apr 7, 2015
src/extensions/default/HealthData/HealthDataManager.js
@@ -110,8 +110,8 @@ define(function (require, exports, module) {
}
/*
- * Check if the health data is to be sent to the server. If the user has enabled tracking, health data will be sent once every 24 hours.
- * Send health data to the server if the period is more than 24 hours.
+ * Check if the Health Data is to be sent to the server. If the user has enabled tracking, Health Data will be sent once every 24 hours.
+ * Send Health Data to the server if the period is more than 24 hours.
@peterflynn
peterflynn Apr 7, 2015 Member

I don't know if we need to capitalize every place we use the phrase "health data," since it's not the official name of the feature or anything. I could see capitalizing (part of) the phrase "Health Report data" since that matches the user-facing feature name. Not a big deal either way though.

@MarcelGerber
MarcelGerber Apr 7, 2015 Member

Ah, I thought that was the official name, and I wanted to harmonize all the different notations a little.

@peterflynn
Member

These changes overall look solid to me. @MarcelGerber note that some of them might be overwritten in the near future (e.g. if we remove the ExtensionManager changes that seem unneeded, or when we tweak the UI further). But I don't see why we couldn't merge this and then make those further changes later.

@prafulVaishnav do you want to take a look at this and merge if it seems good to you too?

@prafulVaishnav
Collaborator

@peterflynn Yes, I will take a look and merge it..

@prafulVaishnav prafulVaishnav merged commit db0bd43 into adobe:master Apr 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@prafulVaishnav
Collaborator

Thanks @MarcelGerber

@MarcelGerber MarcelGerber deleted the MarcelGerber:hd-strings branch Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment