Define all preferences in core #11197

merged 1 commit into from Jun 2, 2015


None yet

3 participants


This will help in #11130 (cc @sprintr).
It defines all preferences we have in core.

sprintr commented Jun 2, 2015

@MarcelGerber This looks fine to me. We can get this in so I can remove them from data.json and add descriptions to them.

abose commented Jun 2, 2015

can we remove data.json after this is merged? (part of #11200 )

sprintr commented Jun 2, 2015

We only need language and path from data.json since they are not prefs but layers of the preferences system. We can hardcode them in main.js

@abose abose merged commit 254927f into master Jun 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
@abose abose deleted the marcel/define-preferences branch Jun 2, 2015
@sprintr sprintr referenced this pull request Jun 18, 2015

Docs for Prefs code hints #11200

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment