New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define all preferences in core #11197

Merged
merged 1 commit into from Jun 2, 2015

Conversation

Projects
None yet
3 participants
@MarcelGerber
Contributor

MarcelGerber commented Jun 2, 2015

This will help in #11130 (cc @sprintr).
It defines all preferences we have in core.

@sprintr

This comment has been minimized.

Show comment
Hide comment
@sprintr

sprintr Jun 2, 2015

Contributor

@MarcelGerber This looks fine to me. We can get this in so I can remove them from data.json and add descriptions to them.

Contributor

sprintr commented Jun 2, 2015

@MarcelGerber This looks fine to me. We can get this in so I can remove them from data.json and add descriptions to them.

@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Jun 2, 2015

Contributor

can we remove data.json after this is merged? (part of #11200 )

Contributor

abose commented Jun 2, 2015

can we remove data.json after this is merged? (part of #11200 )

@sprintr

This comment has been minimized.

Show comment
Hide comment
@sprintr

sprintr Jun 2, 2015

Contributor

We only need language and path from data.json since they are not prefs but layers of the preferences system. We can hardcode them in main.js

Contributor

sprintr commented Jun 2, 2015

We only need language and path from data.json since they are not prefs but layers of the preferences system. We can hardcode them in main.js

abose added a commit that referenced this pull request Jun 2, 2015

@abose abose merged commit 254927f into master Jun 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abose abose deleted the marcel/define-preferences branch Jun 2, 2015

@sprintr sprintr referenced this pull request Jun 18, 2015

Closed

Docs for Prefs code hints #11200

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment